Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for jsonrpc id #298

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Add tests for jsonrpc id #298

merged 2 commits into from
Jun 3, 2020

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Jun 3, 2020

#196 (comment)

part of #211

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #298 into master will increase coverage by 0.2%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #298     +/-   ##
========================================
+ Coverage    30.8%   31.0%   +0.2%     
========================================
  Files         129     129             
  Lines        4893    4905     +12     
  Branches     1549    1549             
========================================
+ Hits         1511    1525     +14     
+ Misses       2297    2294      -3     
- Partials     1085    1086      +1     
Impacted Files Coverage Δ
tendermint/src/rpc/id.rs 60.8% <100.0%> (+60.8%) ⬆️
tendermint/src/merkle.rs 55.5% <0.0%> (ø)
tendermint/src/rpc/endpoint/abci_query.rs 0.0% <0.0%> (ø)
tendermint/src/abci/proof.rs
tendermint/src/merkle/proof.rs 45.4% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622166b...e07e093. Read the comment docs.

greg-szabo
greg-szabo previously approved these changes Jun 3, 2020
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it as it is, although it would be nice to name the function something a bit more telling.

tendermint/src/rpc/id.rs Show resolved Hide resolved
tendermint/src/rpc/id.rs Outdated Show resolved Hide resolved
tendermint/src/rpc/id.rs Show resolved Hide resolved
@greg-szabo greg-szabo merged commit cf0763e into master Jun 3, 2020
@greg-szabo greg-szabo deleted the ismail/jsonrpc_id_tests branch June 3, 2020 15:25
@liamsi liamsi mentioned this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants